test(straiker): assert a saved api_version v1 with an sk_agt_ key routes to v3 by devin-ai-integration[bot] · Pull Request #44153 · BerriAI/litellm

devin-ai-integration · 2026-10-02T05:43:53Z

TLDR

Problem this solves:

fix(guardrails): straiker v3 routes sk_agt_ keys to v3 and fails closed on a missing verdict #44011 landed on main without the test fix from test(straiker): assert a saved api_version v1 with an sk_agt_ key routes to v3 #44106
The checked-in Straiker cell still pins the old v1 route for a saved-v1 sk_agt_ key
integration-extensions is red on main at 826b21a (35/36)

How it solves it:

Cherry-picks test(straiker): assert a saved api_version v1 with an sk_agt_ key routes to v3 #44106 onto main: the cell asserts the v3 route, allow and block, zero v1 webhook calls
The worker-kill chaos cell skips zombie children, so a not yet reaped killed worker cannot raise psutil.ZombieProcess while it waits for the respawn

User Flow

Before: a maintainer watching main after the #44011 merge sees the extensions suite red

CircleCI runs integration-extensions on main
test_explicit_api_version_v1_overrides_key_prefix fails: the sink saw a v3 call, the test wanted the v1 webhook

After: the suite describes the shipped behavior and is green

CircleCI runs integration-extensions on main
test_saved_api_version_v1_with_v3_key_routes_to_v3_not_the_v1_webhook passes with the rest of the file

Relevant issues

Follow-up to #44011 and #44106 (merged into the mirror branch, not main)

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

I have added meaningful tests
The handful of test files covering my change pass locally, e.g. uv run pytest tests/unit/<your_test_file>.py -v. Leave the suites (make test-unit-*, make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more
My PR passes all required CI/CD checks (e.g., lint, schema.d.ts sync check, etc.)
My PR's scope is as isolated as possible; it only solves 1 specific problem
I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Screenshots / Proof of Fix

Test-only change, so the proof is the integration rig from tests/integration/README.md: a real proxy with two workers, real Postgres and Redis, the scripted upstream and a local Straiker sink, no mocks inside litellm

Before (`826b21a`, main)

main's copy of the file run against a two-worker proxy at main's production code: python -m pytest tests/integration/observability/test_straiker_v3_platform.py::test_explicit_api_version_v1_overrides_key_prefix -q
1 failed in 25.95s: the saved-v1 guardrail posted to /api/v3/detect, zero v1 webhook calls at the sink

After (`2a5ff3d`)

python -m pytest tests/integration/observability/test_straiker_v3_platform.py -q (run id 949d1e90b65e4beb8698b4a692b1609c, proxy at 193bd1d, two workers)
36 passed in 77.50s, then a second run with the same selection 36 passed in 73.21s, identical collected and passed sets, no skips
python tests/integration/run.py extensions tests/integration/observability/test_straiker_v3_platform.py tests/integration/observability/test_guardrail_timeout_all_providers.py: 81 passed in 97.00s
CircleCI integration-extensions on this branch at 193bd1d (pipeline 90756): all 81 Straiker and guardrail-timeout cells green except test_burst_survives_one_worker_kill, which hit psutil.ZombieProcess on the killed worker; b229ca0 fixes that cell and 2a5ff3d only reworded the comment above the renamed cell and the file runs 36 passed in 70.49s through run.py again. CircleCI integration-extensions at b229ca0 (pipeline 90762): all 81 Straiker and guardrail-timeout cells green; the only reds in that job are two unrelated observability cells that also fail on main

Type

✅ Test

Final Attestation

The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

Link to Devin session: https://app.devin.ai/sessions/16f17e78d5b6462991838dcfb24e3249
Open in Devin Desktop: https://app.devin.ai/desktop/session/16f17e78d5b6462991838dcfb24e3249?variant=devin
Requested by: @yucheng-berri

Note

Low Risk
Test-only changes to integration assertions and worker discovery; no production code paths modified.

Overview
Aligns Straiker integration tests with shipped routing: a guardrail saved with api_version="v1" but an sk_agt_ key must hit v3 detect, not the v1 webhook.

The old cell expected explicit v1/litellm webhook behavior; it is replaced by test_saved_api_version_v1_with_v3_key_routes_to_v3_not_the_v1_webhook, which covers allow (200 + one v3 call, provider reached, zero v1 sink hits) and block (400 + block message, v3 only, no provider).

Separately hardens the worker-kill chaos test: _uvicorn_workers now uses _is_live_worker to ignore zombie children and tolerate psutil errors while waiting for respawn, avoiding flaky psutil.ZombieProcess after SIGKILL.

^{Reviewed by Cursor Bugbot for commit 2a5ff3d. Bugbot is set up for automated code reviews on this repo. Configure here.}

…tes to v3 (#44106) Co-authored-by: yucheng <yucheng@berri.ai> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration · 2026-10-02T05:43:56Z

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

Disable automatic comment, CI, and merge conflict monitoring

CLAassistant · 2026-10-02T05:44:01Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yucheng-berri
❌ devin-ai-integration[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

greptile-apps · 2026-10-02T05:46:30Z

Confidence Score: 5/5

[Low risk] Test case for API version routing behavior.

The PR appears safe to merge.

Summary

This test-only PR updates the saved-v1 Straiker case to assert v3 routing for an sk_agt_ key, and makes the worker-kill test tolerate zombie children while waiting for a replacement worker.

_{Reviews (2) · Last reviewed commit: "test(straiker): describe the saved v1 ce..."}

devin-ai-integration

🔍 Devin Review: 2 flags

Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)

codecov · 2026-10-02T05:59:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

…after a kill Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration · 2026-10-02T08:10:58Z

@greptileai

yucheng-berri · 2026-10-02T08:11:31Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 2a5ff3d. Configure here.}

test(straiker): assert a saved api_version v1 with an sk_agt_ key rou…

193bd1d

…tes to v3 (#44106) Co-authored-by: yucheng <yucheng@berri.ai> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration Bot requested a review from a team October 2, 2026 05:43

devin-ai-integration Bot assigned yucheng-berri Oct 2, 2026

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread tests/integration/observability/test_straiker_v3_platform.py

devin-ai-integration Bot commented Oct 2, 2026

View reviewed changes

yucheng-berri and others added 2 commits October 2, 2026 06:47

test(straiker): ignore zombie workers when counting uvicorn children …

b229ca0

…after a kill Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

test(straiker): describe the saved v1 cell by the v3 route it asserts

2a5ff3d

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

cursor Bot reviewed Oct 2, 2026

View reviewed changes

yucheng-berri approved these changes Oct 2, 2026

View reviewed changes

yucheng-berri added the run-ci label Oct 2, 2026

yucheng-berri merged commit 7be2983 into main Oct 2, 2026
130 of 147 checks passed

yucheng-berri deleted the litellm_straiker_v3_saved_v1_cell_main branch October 2, 2026 08:31

PhimmStraiker mentioned this pull request Oct 3, 2026

chore(release): backport #41880, #43956, #44011 to stable/1.103.x #44377

Open

3 of 5 tasks

Navigation Menu

Repository navigation

test(straiker): assert a saved api_version v1 with an sk_agt_ key routes to v3 - #44153

test(straiker): assert a saved api_version v1 with an sk_agt_ key routes to v3#44153
yucheng-berri merged 3 commits into
mainfrom
litellm_straiker_v3_saved_v1_cell_main

devin-ai-integration Bot commented Oct 2, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot commented Oct 2, 2026

Uh oh!

CLAassistant commented Oct 2, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Oct 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

codecov Bot commented Oct 2, 2026

Uh oh!

devin-ai-integration Bot commented Oct 2, 2026

Uh oh!

yucheng-berri commented Oct 2, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

devin-ai-integration Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TLDR

User Flow

Relevant issues

Pre-Submission checklist

Screenshots / Proof of Fix

Before (826b21a, main)

After (2a5ff3d)

Type

Final Attestation

Uh oh!

devin-ai-integration Bot commented Oct 2, 2026

Uh oh!

CLAassistant commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

🔍 Devin Review: 2 flags

Uh oh!

codecov Bot commented Oct 2, 2026

Codecov Report

Uh oh!

devin-ai-integration Bot commented Oct 2, 2026

Uh oh!

yucheng-berri commented Oct 2, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

devin-ai-integration Bot commented Oct 2, 2026 •

edited

Loading

Before (`826b21a`, main)

After (`2a5ff3d`)

CLAassistant commented Oct 2, 2026 •

edited

Loading

greptile-apps Bot commented Oct 2, 2026 •

edited

Loading